Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge policies repo into larger repo #764

Merged
merged 102 commits into from
May 25, 2024

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Mar 11, 2024

This PR fixes issue #760.
As mentioned by Yo, it makes sense to have these assets located in one central repository.

Changes made:
All the resources currently housed in the policies-procedures-and-docs repo have been migrated to the main repo, where the majority of website assets are located.

Note for reviewers:
After this is thoroughly reviewed and merged, we should consider archiving the policies repo first and only delete when we have seen that this system works.

Thank you!

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for ols-bebatut ready!

Name Link
🔨 Latest commit 4c014d6
🔍 Latest deploy log https://app.netlify.com/sites/ols-bebatut/deploys/6651e96f3ba48600080ea15b
😎 Deploy Preview https://deploy-preview-764--ols-bebatut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bebatut
Copy link
Member

bebatut commented Mar 12, 2024

Thanks @NPDebs

I have doubts about the structure. For example,

  • code of conduct should probably go to the root
  • open seeds procedure to the openseeds within the corresponding cohort folder

@yochannah what do you think?

@NPDebs
Copy link
Collaborator Author

NPDebs commented Mar 12, 2024

I have doubts about the structure

I hadn't thought that deeply about the structure. Since the goal was to put the resources in one place, I mostly just cloned the policies repo and copied the files into a new directory. No folder reshuffling,

@bebatut
Copy link
Member

bebatut commented Mar 13, 2024

yes the goal was to put the resources in one place, but maybe good to organize it where it fits best

@NPDebs
Copy link
Collaborator Author

NPDebs commented Mar 13, 2024

yes the goal was to put the resources in one place, but maybe good to organize it where it fits best

True. 💯

@yochannah
Copy link
Member

yochannah commented Mar 13, 2024

Agreed. I think, probably, some of this might need to go under the Open Seeds or training pages sub-folders, and for other groups of pages we might want an index page of some sort. Tagging @iramosp in case she has anything she wants to add (maybe not, I know you're busy with Nebula!)

@NPDebs NPDebs requested review from bebatut and yochannah April 4, 2024 14:16
Copy link
Member

@yochannah yochannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure looks clear to me. I'll wait for Bérénice to approve.

Copy link
Member

@bebatut bebatut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Some comments

  • The template for cohort calls should be in the cohort GitHub repo
  • All policies related to Open Seeds would be better in the Open Seeds folder and linked to them from the menu
  • Each document here could be a proper page (only need have the metadata on the top)
  • If documents are page, email addresses and links to website could be done using Jekyll variables (easier to update - many are currently outdated)

openseeds/ols-5/cohort-notes/week-06.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
openseeds/ols-5/cohort-emails/README.md Outdated Show resolved Hide resolved
policies-procedures-and-docs/LICENCE.md Outdated Show resolved Hide resolved
NPDebs and others added 3 commits April 6, 2024 15:43
_includes/default-header.html Show resolved Hide resolved
Comment on lines 66 to 71
<a class="navbar-item" href="{% link openseeds/cohort-procedures-and-templates/cohort-call-facilitator-guide.md %}"> Cohort Call Facilitator Guide </a>
<a class="navbar-item" href="{% link openseeds/cohort-procedures-and-templates/expert-guide.md %}"> Expert Guide </a>
<a class="navbar-item" href="{% link openseeds/cohort-procedures-and-templates/graduation-guide.md %}"> Graduation Guide </a>
<a class="navbar-item" href="{% link openseeds/cohort-procedures-and-templates/microgrants.md %}"> Microgrants </a>
<a class="navbar-item" href="{% link openseeds/cohort-procedures-and-templates/speedblog.md %}"> Speedblog </a>
<a class="navbar-item" href="{% link openseeds/cohort-procedures-and-templates/video-facilitator-guide.md %}"> Video Facilitator Guide </a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

policies-procedures-and-docs/communications/slack-guide.md Outdated Show resolved Hide resolved
@bebatut
Copy link
Member

bebatut commented May 2, 2024

@NPDebs have you seen that the check-internal-links linting is failing? I fixed the other linting tests in #768

@NPDebs
Copy link
Collaborator Author

NPDebs commented May 2, 2024

I have indeed, and intend to fix them. 🙏🏽
Crazy busy week with CW24 and Carpentries. Sorry! :(

@NPDebs
Copy link
Collaborator Author

NPDebs commented May 4, 2024

Fixed!

Next on the agenda:

  • Use Jekyll variable for the email.
  • Debug the index page outlining the content of the policies folder.
  • Individualise the items in the policies dropdown menu (in main & openseeds page).

@NPDebs
Copy link
Collaborator Author

NPDebs commented May 4, 2024

Update:

Along with some minor adjustments, site.pages worked for displaying the policies in one page. See below:

Screenshot 2024-05-04 at 17 10 28

Then, I filtered to include docs in /openseeds folder. That didn't work out so well.

@NPDebs
Copy link
Collaborator Author

NPDebs commented May 4, 2024

Yaaay, my new filter worked! 🎉 🕺

@NPDebs
Copy link
Collaborator Author

NPDebs commented May 4, 2024

For some reason, the policies-procedures-and-docs folder is not being built in the _site folder. It is causing us to run into (74) internal link errors. 💔

@NPDebs
Copy link
Collaborator Author

NPDebs commented May 25, 2024

Of course it worked! 😭

@bebatut
Copy link
Member

bebatut commented May 25, 2024

Thanks a lot @NPDebs for that work!

@bebatut bebatut merged commit 6cc5b70 into open-life-science:main May 25, 2024
7 of 10 checks passed
@NPDebs
Copy link
Collaborator Author

NPDebs commented May 25, 2024

And the record for the fastest debug time goes to @bebatut. Thank you! ❤️

@NPDebs NPDebs deleted the migrate_policy branch July 24, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants