feat: Change defaultSize param names

feat: Change defaultSize param names feat: Change defaultSize param names
open-mmlab · Aug 10, 2023 · 99c3864 · 99c3864
1 parent d259ae8
commit 99c3864
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/packages/lb-components/src/components/attributeList/components/limitPopover/index.tsx b/packages/lb-components/src/components/attributeList/components/limitPopover/index.tsx
@@ -16,8 +16,8 @@ const LimitPopover = ({
   const sizeRange = limit?.sizeLimit?.sizeRange;
   const positionLimit = limit?.positionLimit;
 
-  const { heightDefault, lengthDefault, widthDefault } = defaultSize;
-  const { heightMax, heightMin, lengthMax, lengthMin, widthMax, widthMin } = sizeRange;
+  const { heightDefault, depthDefault, widthDefault } = defaultSize;
+  const { heightMax, heightMin, depthMax, depthMin, widthMax, widthMin } = sizeRange;
   const { XMin, XMax, YMin, YMax, ZMin, ZMax } = positionLimit;
 
   return (
@@ -30,7 +30,7 @@ const LimitPopover = ({
               <div>
                 【{t('DefaultSize')}】
               </div>
-              <span>{`${t('Length')}: ${lengthDefault}m、`}</span>
+              <span>{`${t('Length')}: ${depthDefault}m、`}</span>
               <span>{`${t('Width')}: ${widthDefault}m、`}</span>
               <span>{`${t('Height')}: ${heightDefault}m`}</span>
             </div>
@@ -39,7 +39,7 @@ const LimitPopover = ({
           {sizeRange && (
             <div style={{ marginBottom: '24px' }}>
               <div>*{t('NormalSizeRange')}</div>
-              <span>{`${t('Length')}:: ${lengthMin}~${lengthMax}m、`}</span>
+              <span>{`${t('Length')}:: ${depthMin}~${depthMax}m、`}</span>
               <span>{`${t('Width')}: ${widthMin}~${widthMax}m、`}</span>
               <span>{`${t('Height')}: ${heightMin}~${heightMax}m`}</span>
             </div>

diff --git a/packages/lb-components/src/components/pointCloudView/hooks/usePointCloudViews.ts b/packages/lb-components/src/components/pointCloudView/hooks/usePointCloudViews.ts
@@ -1000,7 +1000,7 @@ export const usePointCloudViews = () => {
       const newBoxParams: IPointCloudBox = {
         ...selectedBox.info,
         width: Number(defaultSize.widthDefault),
-        depth: Number(defaultSize.lengthDefault),
+        depth: Number(defaultSize.depthDefault),
         height: Number(defaultSize.heightDefault),
       }
       const newPointCloudBoxList = updateSelectedBoxes([newBoxParams]);

diff --git a/packages/lb-utils/src/types/base.ts b/packages/lb-utils/src/types/base.ts
@@ -2,16 +2,16 @@
 export interface ISizeRange {
   heightMax?: string;
   heightMin?: string;
-  lengthMax?: string;
-  lengthMin?: string;
+  depthMax?: string;
+  depthMin?: string;
   widthMax?: string;
   widthMin?: string;
 }
 
 // Default size
 export interface IDefaultSize {
   heightDefault: string;
-  lengthDefault: string;
+  depthDefault: string;
   widthDefault: string;
 }