-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor SPVCNN & MinkUNet #2830
base: dev-1.x
Are you sure you want to change the base?
[Refactor] Refactor SPVCNN & MinkUNet #2830
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2830 +/- ##
===========================================
- Coverage 46.70% 46.65% -0.06%
===========================================
Files 277 276 -1
Lines 23635 23658 +23
Branches 3704 3703 -1
===========================================
- Hits 11039 11037 -2
- Misses 11892 11915 +23
- Partials 704 706 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to discuss the risk of deleting existing MinkUNet
and Cylinder3D
implementations.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
This PR is ready after #2711 is merged.
VoxelSegmentor
, so that all voxel-based segmentors will share the same structure.BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist