[fix] align the default anchor_generator config of Anchor3DHead with the Anchor3DRangeGenerator specification #2856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm new to mmdetection3d. When I try to leverage mmdetection3d's anchor head module in my own project, I found there is a mismatch in the default config value of Anchor3DRangeGenerator( in mmdet3d/models/dense_heads/anchor3d_head.py) and the Anchor3DRangeGenerator ( in mmdet3d/models/task_modules/anchor/anchor_3d_generator.py).
Modification
Before modification, the default init value of Anchor3DRangeGenerator is as follows (line 55-62 in mmdet3d/models/dense_heads/anchor3d_head.py ):
The __init__value of Anchor3DRangeGenerator is as follows: ( line 43 -49 in mmdet3d/models/task_modules/anchor/anchor_3d_generator.py)
ranges: List[List[float]],
sizes: List[List[float]] = [[3.9, 1.6, 1.56]],
scales: List[int] = [1],
rotations: List[float] = [0, 1.5707963],
custom_values: Tuple[float] = (),
reshape_out: bool = True,
size_per_range: bool = True) -> None:
Specifically, I correct the default init anchor_generator value of anchor_generator (the fomer one) to match with the definition of the Anchor3DRangeGenerator.
After modified,
Thank you for all developers for creating such a wonderful work! This work really helps my research.
I'm willing to join this community and contribute more in the future!