[Fix] Close MLflowVisBackend only if active (#1144) #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HAOCHENYE
approved these changes
May 25, 2023
zhouzaida
approved these changes
May 25, 2023
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is currently a bug (#1144) when running multi GPU training with MLflowVisBackend, wherein the VisBackend seemingly will try to close on multiple processes, when it can only close on one of the processes. Checking for any
self.cfgin theclose()method would cause the script to crash.Modification
The check
hasattr(self, '_mlflow')was only done for a ending the mlflow run (self._mlflow.end_run()). I propose to check this at the start of theclose()method instead.