Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept UCX < 1.9 #13028

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bosilca
Copy link
Member

@bosilca bosilca commented Jan 9, 2025

Don't just print a warning if the detected UCX version is too old, bail out and demand a newer version (at least 1.9, now more than 4 years old).

Fixes #13017.

@@ -75,14 +75,16 @@ AC_DEFUN([OMPI_CHECK_UCX],[
AS_IF([test "${ompi_check_ucx_cv_have_version_1_8}" = "yes"],
[AC_MSG_WARN([UCX support skipped because version 1.8.x was found, which has a known catastrophic issue.])
ompi_check_ucx_happy=no])])
AC_PREPROC_IFELSE([AC_LANG_PROGRAM([[
AC_PREPROC_IFELSE([AC_LANG_PROGRAM([[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the check above for version 1.8.x be removed entirely then?

Don't just print a warning if the UCX version is too old, bail out and
demand a newer version (at least 1.9, now more than 4 years old).

Fixes open-mpi#13017.

Signed-off-by: George Bosilca <[email protected]>
@bosilca bosilca force-pushed the topic/require_at_least_ucx_1.9 branch from 9938797 to 9288158 Compare February 1, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile error on "ucs_memory_type_t"
2 participants