-
Notifications
You must be signed in to change notification settings - Fork 906
add support for riscv64 timer #13324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left few comments, but I can't test this and I don't think our CI run on any risc64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now ready to go. I did not approve it because I don't think we can test it. Do we have a CI or MTT running on risc64 ?
I agree with George that it would be nice to have testing for RISC-V if we're going to add RISC-V support. We do not currently have anything either as a CI hook or nightly tests. @heyujiao99 is this something that your organization might be able to help out with? Thanks for addressing George's feedback, but it would also be good to squash your commits before we approve / merge. |
I’d be happy to help set up the RISC-V64 test workflow, but I found that GitHub currently only provides Ubuntu images for x86 and ARM. Referring to other projects’ RISC-V testing approaches (e.g., OpenBLAS), using riscv-gnu-toolchain and qemu-riscv64 to compile and test could also work. Would this be an acceptable solution? @bwbarrett @bosilca |
Signed-off-by: heyujiao99 <[email protected]>
Hello, I‘ve added the RISC-V 64 CI test implementation, could you please help review this code again? |
Hi, this patch add support for riscv64 timer,