adding tests

Signed-off-by: Jaydip Gabani <[email protected]>
open-policy-agent · Mar 21, 2024 · 604e13c · 604e13c
1 parent 4aabc45
commit 604e13c
Show file tree

Hide file tree

Showing 6 changed files with 90 additions and 59 deletions.
diff --git a/constraint/pkg/client/client_internal_test.go b/constraint/pkg/client/client_internal_test.go
@@ -102,7 +102,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -137,7 +137,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -175,7 +175,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -209,7 +209,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -246,7 +246,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -286,7 +286,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -331,7 +331,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Wanted 1 template in driver C; got %d", len(driverC.GetTemplateCode()))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -368,7 +368,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Wanted 0 templates in driver C; got %d", len(driverC.GetTemplateCode()))
 		}
 
-		resp, err = client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err = client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -409,7 +409,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -443,7 +443,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -488,7 +488,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -518,7 +518,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err = client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err = client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -548,7 +548,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err = client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err = client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -589,7 +589,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -623,7 +623,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -672,7 +672,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -719,7 +719,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver C has unexpected state: %v", driverC.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -781,7 +781,7 @@ func TestMultiDriverAddTemplate(t *testing.T) {
 			t.Errorf("Driver A has unexpected state: %v", driverA.GetConstraintsForTemplate(anyTemplate))
 		}
 
-		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "audit.gatekeeper.sh")
+		resp, err := client.Review(ctx, handlertest.NewReview("", "foo", "bar"), "")
 		if err != nil {
 			t.Fatal(err)
 		}

diff --git a/constraint/pkg/client/client_review_benchmark_test.go b/constraint/pkg/client/client_review_benchmark_test.go
@@ -110,7 +110,7 @@ func BenchmarkClient_Review(b *testing.B) {
 					// Run Review queries in parallel.
 					b.RunParallel(func(pb *testing.PB) {
 						for pb.Next() {
-							_, err := c.Review(ctx, tt.review, "audit.gatekeeper.sh")
+							_, err := c.Review(ctx, tt.review, "")
 							if err != nil {
 								b.Fatal(err)
 							}

diff --git a/constraint/pkg/client/client_test.go b/constraint/pkg/client/client_test.go
@@ -968,6 +968,7 @@ func TestClient_AddConstraint(t *testing.T) {
 				handlertest.TargetName: true,
 			},
 		},
+		{},
 	}
 
 	for _, tc := range tcs {

diff --git a/constraint/pkg/client/clienttest/cts/constraints.go b/constraint/pkg/client/clienttest/cts/constraints.go
@@ -46,15 +46,15 @@ func MakeScopedEnforcementConstraint(t testing.TB, kind, name string, actions []
 
 	scopedEnforcementActions := make([]interface{}, len(actions))
 
-	for _, action := range actions {
+	for i, action := range actions {
 		enfocementPoints := make([]interface{}, len(eps))
-		for _, point := range eps {
-			enfocementPoints = append(enfocementPoints, map[string]interface{}{"name": point})
+		for j, point := range eps {
+			enfocementPoints[j] = map[string]interface{}{"name": point}
 		}
-		scopedEnforcementActions = append(scopedEnforcementActions, map[string]interface{}{
+		scopedEnforcementActions[i] = map[string]interface{}{
 			"enforcementPoints": enfocementPoints,
 			"action":            action,
-		})
+		}
 	}
 
 	u := &unstructured.Unstructured{Object: map[string]interface{}{

diff --git a/constraint/pkg/client/drivers/rego/driver_unit_test.go b/constraint/pkg/client/drivers/rego/driver_unit_test.go
@@ -211,11 +211,8 @@ func TestDriver_Query(t *testing.T) {
 	if len(qr.Results) == 0 {
 		t.Fatalf("got 0 errors on data-less query; want 1")
 	}
-	eps := []string{"deny", "warn"}
-	for i, r := range qr.Results {
-		if r.EnforcementAction != eps[i] {
-			t.Fatalf("got %s, want %s", r.EnforcementAction, eps[i])
-		}
+	if len(qr.Results) != 2 {
+		t.Fatalf("got 0 errors on data-less query; want 1")
 	}
 
 	qr, err = d.Query(
-Original file line number
+Diff line change
@@ Expand Up / @@ -968,6 +968,7 @@ func TestClient_AddConstraint(t *testing.T) { @@
     				handlertest.TargetName: true,
     			},
     		},
+    		{},
     	}
     	for _, tc := range tcs {
@@ Expand Down @@