Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anyObject was not fully plumbed to compiler, streamline plumbing to fix #437

Merged
merged 1 commit into from
May 24, 2024

Conversation

maxsmythe
Copy link
Contributor

@maxsmythe maxsmythe commented May 24, 2024

variables.anyObject isn't recognized in-process until this is merged.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 53.06%. Comparing base (76869f8) to head (d414083).
Report is 20 commits behind head on master.

Files Patch % Lines
...kg/client/drivers/k8scel/transform/cel_snippets.go 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   54.68%   53.06%   -1.62%     
==========================================
  Files          71      104      +33     
  Lines        5241     6554    +1313     
==========================================
+ Hits         2866     3478     +612     
- Misses       2073     2714     +641     
- Partials      302      362      +60     
Flag Coverage Δ
unittests 53.06% <52.94%> (-1.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit 5368a3b into open-policy-agent:master May 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants