chore: require-sync gk update #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Thanks for the contribution @acpana!
For the failing CI: while you could add the updated go.work.sum, we don't really need to include that file in the repository as it's automatically generated. I recommend you delete https://github.com/acpana/gatekeeper-library/blob/acpana/update-gk/go.work.sum and add go.work.sum to https://github.com/acpana/gatekeeper-library/blob/acpana/update-gk/.gitignore
I also included a note below on some easy ways to fix the main.go lint check.
Let me know if you need any assistance, cheers!
go get github.com/open-policy-agent/gatekeeper/v3@366ba79 but when 3.14 is released, we should move to the release Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/update-gk
branch
from
c6226d3 to
21448d7
Compare
apeabody
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go get github.com/open-policy-agent/gatekeeper/v3@366ba79But probably want to wait on gatekeeper 3.14 before making this change
Special notes for your reviewer:
parserpackage was moved as per feedback from open-policy-agent/gatekeeper#2852