Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump mutation cr from alpha to v1 #445

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

fseldow
Copy link
Contributor

@fseldow fseldow commented Dec 5, 2023

What this PR does / why we need it:
the sample mutate assign api is too old

Which issue(s) does this PR fix (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #444

already run

Special notes for your reviewer:
I fail to find the test framework for mutate

@fseldow fseldow requested a review from a team as a code owner December 5, 2023 10:53
f
Signed-off-by: Xinhe Li <[email protected]>
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @fseldow!

Looks like mutations.gatekeeper.sh/v1 was added in GK v3.10, so LGTM!

A second maintainer will also need to review and approve.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR! @fseldow

@ritazh ritazh merged commit 1136967 into open-policy-agent:master Dec 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump mutate assign api version from alpha to v1
3 participants