fix(k8spsphostnetworkingports): null check container.ports #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianKatz
force-pushed
the
fix-container-ports-undefined
branch
from
0485176 to
0f18497
Compare
apeabody
reviewed
Aug 26, 2024
maxsmythe
approved these changes
Aug 26, 2024
julianKatz
force-pushed
the
fix-container-ports-undefined
branch
3 times, most recently
from
d1c172c to
1a2811e
Compare
Previously, the `badContainers` section of the K8sNative validation logic did not verify that the `ports` variable was set on a container spec in a pod. As this template's purpose is to verify that the specified ports fall within a given range, we would expect that _no ports_ is not a violation. Signed-off-by: juliankatz <[email protected]>
julianKatz
force-pushed
the
fix-container-ports-undefined
branch
from
1a2811e to
2fdf9ca
Compare
JaydipGabani
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
badContainerssection of the K8sNative validation logic did not verify that theportsvariable was set on a container spec in a pod. As this template's purpose is to verify that the specified ports fall within a given range, we would expect that no ports is not a violation.