fix(k8srequiredlabels): CEL broke when allowedRegex was empty #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CEL implementation of this policy always expected the `allowedRegex` value to be set for a given `key` value in the contraint parameters. Existing users of the template could (via rego) require only that a given label key exist, but assert nothing about the value of that label. This change makes the CEL implementation uphold that same contract. Signed-off-by: juliankatz <[email protected]>
apeabody
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Thanks for catching @julianKatz!
This highlights the value of the Rego engine unit tests (e.g. https://github.com/open-policy-agent/gatekeeper-library/blob/master/src/general/requiredlabels/src_test.rego), as they provide far more code coverage than just the universal integration tests(https://github.com/open-policy-agent/gatekeeper-library/blob/master/library/general/requiredlabels/suite.yaml).
JaydipGabani
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CEL implementation of this policy always expected the
allowedRegexvalue to be set for a givenkeyvalue in the contraint parameters.Existing users of the template could (via rego) require only that a given label key exist, but assert nothing about the value of that label.
This change makes the CEL implementation uphold that same contract.