chore: Bump GATOR_VERSION to 1.17.0 from 1.16.3 #586
Conversation
In the 1.17.0 version of gator (which I've been using on my machine), the `--experimental-enable-k8s-native-validation` flag has been renamed to `--enable-k8s-native-validation`. This was preventing me from using the `make verify-gator` target. This PR fixes updates the GATOR_VERSION and changes the flag. Signed-off-by: juliankatz <[email protected]>
|
@julianKatz - Probably want to bump to match? |
|
@apeabody correct, we'll need to support both --experimental and non-experimental flags since we support 2 versions |
| @@ -50,17 +50,17 @@ test-integration: | |||
| .PHONY: verify-gator | |||
| verify-gator: | |||
| ifeq ($(POLICY_ENGINE), rego) | |||
| gator verify ./... --experimental-enable-k8s-native-validation=false | |||
| gator verify ./... --enable-k8s-native-validation=false | |||
There was a problem hiding this comment.
We need a conditional check here for GATOR_VERSION, for < 3.17 use experimental flag, for >= 3.17 use updated flag.
|
This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
|
@julianKatz Are you still working on this? |
|
if we wait until 3.18 is cut, we should be good with this PR after updating version to 3.18 |
@julianKatz This PR is really close! can you pls update this to 3.17.1, 3.18.0? |
apeabody
force-pushed
the
update-gator-version
branch
from
8f73019 to
684a719
Compare
Signed-off-by: Andrew Peabody <[email protected]>
apeabody
force-pushed
the
update-gator-version
branch
from
684a719 to
6ab6bca
Compare
Hi @ritazh - Can you please check if this is now ready? |
In the 1.17.0 version of gator (which I've been using on my machine), the
--experimental-enable-k8s-native-validationflag has been renamed to--enable-k8s-native-validation. This was preventing me from using themake verify-gatortarget.This PR fixes updates the GATOR_VERSION and changes the flag.