fix(k8spspprocmount): exemptImages CEL bug #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianKatz
changed the title
JaydipGabani
requested changes
Aug 29, 2024
...security-policy/proc-mount/1.1.1/samples/psp-proc-mount/example_disallowed_exempt_image.yaml
Outdated
Show resolved
Hide resolved
julianKatz
force-pushed
the
k8spspprocmount-exemptImages
branch
from
99079f9 to
74ebb28
Compare
|
Thanks for the review @JaydipGabani! This is ready for another look. |
I recently found (open-policy-agent#584) that some K8sNativeValidation implementations of certain templates that iterate over and exempt containers by image had a bug preventing the exemption logic from working. I've fixed that bug here by mapping from `container` struct to `container.image` string. I've also added a suite test to verify this. That case fails without the change to the CEL logic. Signed-off-by: juliankatz <[email protected]>
julianKatz
force-pushed
the
k8spspprocmount-exemptImages
branch
from
bea5c8e to
86996db
Compare
|
@julianKatz I just pulled this update and it seems to break functionality getting the following violations: Also some variants of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently found (#584) that some K8sNativeValidation implementations of certain templates that iterate over and exempt containers by image had a bug preventing the exemption logic from working.
I've fixed that bug here by mapping from
containerstruct tocontainer.imagestring. I've also added a suite test to verify this. That case fails without the change to the CEL logic.