fix(k8sPSPHostFilesystem): null-check on volumes #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A K8sNativeValidation implementation of this template was added in open-policy-agent#547. When testing it, I found that a Pod lacking the `volumes` field would yield a null-pointer style error on the CEL expression: ``` unexpected number of violations: got 1 violations but want none: got messages [expression '(has(request.operation) && request.operation == "UPDATE") || size(variables.badHostPaths) == 0' resulted in error: composited variable "badHostPaths" fails to evaluate: composited variable "volumes" fails to evaluate: no such key: volumes] ``` This PR adds a `has(` check to prevent that null pointer, and adds a suite test case that fails without the code change. Signed-off-by: juliankatz <[email protected]>
julianKatz
force-pushed
the
fix-psp-host-filesystem
branch
from
b0d012c to
8caaa18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A K8sNativeValidation implementation of this template was added in #547.
When testing it, I found that a Pod lacking the
volumesfield would yield a null-pointer style error on the CEL expression:This PR adds a
has(check to prevent that null pointer, and adds a suite test case that fails without the code change.