chore(k8spspcapabilities): double newlines can cause yamllint breakage #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
approved these changes
Sep 7, 2024
julianKatz
force-pushed
the
remove-double-newlines
branch
from
b229274 to
3d0e1de
Compare
apeabody
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
Thanks @julianKatz!
I think this is good to merge once all the tests are green.
The default value for newlines in the yamllint linter (a commonly used tool for linting yaml) is 2. See https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.empty_lines for more info. This PR removes some unnecessary newlines in a rego file that trigger this linter rule. Signed-off-by: juliankatz <[email protected]>
julianKatz
force-pushed
the
remove-double-newlines
branch
from
3d0e1de to
6dfbb3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for newlines in the yamllint linter (a commonly used tool for linting yaml) is 2. See
https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.empty_lines for more info.
This PR removes some unnecessary newlines in a rego file that trigger this linter rule.