fixing tests

Signed-off-by: Jaydip Gabani <[email protected]>

pkg/controller/constrainttemplate/constrainttemplate_controller_test.go

@@ -679,16 +679,11 @@ func TestReconcile(t *testing.T) {
 			if vapBindingCreationTime.Before(blockTime) {
 				return fmt.Errorf("VAPBinding should be created after default wait")
 			}
-			err = retry.OnError(testutils.ConstantRetry, func(_ error) bool {
-				return true
-			}, func() error {
-				return c.Delete(ctx, vapBinding)
-			})
-			if err != nil {
-				logger.Error(err, "delete vapBinding")
-				t.Fatal(err)
+
+			if err := c.Delete(ctx, cstr); err != nil {
+				return err
 			}
-			return nil
+			return c.Delete(ctx, vapBinding)
 		})
 		if err != nil {
 			t.Fatal(err)
@@ -815,7 +810,7 @@ func TestReconcile(t *testing.T) {
 			}
 			vapBindingCreationTime := vapBinding.GetCreationTimestamp().Time
 			if vapBindingCreationTime.Before(blockTime) {
-				t.Fatal("VAPBinding should not be created before the timestamp")
+				return fmt.Errorf("VAPBinding should not be created before the timestamp")
 			}
 			return nil
 		})