Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changed the process to expand yaml so that maxUnavailable, etc. can be used. #3199

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kahirokunn
Copy link

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@kahirokunn kahirokunn requested a review from a team as a code owner December 24, 2023 10:59
@kahirokunn kahirokunn changed the title Changed the process to expand yaml so that maxUnavailable, etc. can be used. chore: Changed the process to expand yaml so that maxUnavailable, etc. can be used. Dec 24, 2023
@sozercan
Copy link
Member

sozercan commented Jan 8, 2024

@kahirokunn thanks for the PR! Gatekeeper helm chart is autogenerated and these changes will be clobbered in the next release. Please refer to Contributing to Helm Chart for modifying the Helm chart.

@kahirokunn kahirokunn force-pushed the pdb branch 2 times, most recently from 5c211b4 to 3a8c4bd Compare January 30, 2024 02:58
@kahirokunn
Copy link
Author

@sozercan thx. done.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.48%. Comparing base (0bac5b0) to head (a51aff0).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3199      +/-   ##
==========================================
- Coverage   54.49%   54.48%   -0.02%     
==========================================
  Files         134      134              
  Lines       12329    12329              
==========================================
- Hits         6719     6717       -2     
- Misses       5117     5118       +1     
- Partials      493      494       +1     
Flag Coverage Δ
unittests 54.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Apr 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Apr 28, 2024
@kahirokunn
Copy link
Author

@sozercan Hello 👀

@JaydipGabani
Copy link
Contributor

@kahirokunn can you instead changing vairable minAvailable, introduce a new variable maxUnavailable and respective field in PDB? that way by not chaning original variable we are not breaking users(that are using maxAvailable variable).

Copy link

stale bot commented Jul 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2024
@stale stale bot closed this Jul 30, 2024
@kahirokunn
Copy link
Author

/reopen

@kahirokunn
Copy link
Author

@JaydipGabani Introducing a new variable, maxUnavailable, instead of changing minAvailable is a thoughtful suggestion to avoid breaking existing users. However, minAvailable and maxUnavailable cannot be specified together as they are mutually exclusive. Adding maxUnavailable alone will not function correctly in the current setup.

@kahirokunn
Copy link
Author

@sozercan Hi 😢

@JaydipGabani JaydipGabani reopened this Jul 30, 2024
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stale stale bot removed the stale label Jul 30, 2024
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kahirokunn kahirokunn force-pushed the pdb branch 2 times, most recently from 86b502e to c7c2a20 Compare September 9, 2024 05:57
Signed-off-by: kahirokunn <[email protected]>
@kahirokunn
Copy link
Author

@ritazh thx for your review 🙏 how about now?

Copy link

stale bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 9, 2024
@kahirokunn
Copy link
Author

/refresh

@stale stale bot removed the stale label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants