-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Changed the process to expand yaml so that maxUnavailable, etc. can be used. #3199
base: master
Are you sure you want to change the base?
Conversation
@kahirokunn thanks for the PR! Gatekeeper helm chart is autogenerated and these changes will be clobbered in the next release. Please refer to Contributing to Helm Chart for modifying the Helm chart. |
5c211b4
to
3a8c4bd
Compare
@sozercan thx. done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3199 +/- ##
==========================================
- Coverage 54.49% 54.48% -0.02%
==========================================
Files 134 134
Lines 12329 12329
==========================================
- Hits 6719 6717 -2
- Misses 5117 5118 +1
- Partials 493 494 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
@sozercan Hello 👀 |
@kahirokunn can you instead changing vairable |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
/reopen |
@JaydipGabani Introducing a new variable, maxUnavailable, instead of changing minAvailable is a thoughtful suggestion to avoid breaking existing users. However, minAvailable and maxUnavailable cannot be specified together as they are mutually exclusive. Adding maxUnavailable alone will not function correctly in the current setup. |
@sozercan Hi 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
charts/gatekeeper/templates/gatekeeper-controller-manager-poddisruptionbudget.yaml
Outdated
Show resolved
Hide resolved
...t_staging/charts/gatekeeper/templates/gatekeeper-controller-manager-poddisruptionbudget.yaml
Outdated
Show resolved
Hide resolved
86b502e
to
c7c2a20
Compare
…. can be used. Signed-off-by: kahirokunn <[email protected]>
Signed-off-by: kahirokunn <[email protected]>
@ritazh thx for your review 🙏 how about now? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
/refresh |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: