fix(helm): avoid GitOps diff on matchConditions #3383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3383 +/- ##
==========================================
- Coverage 54.49% 46.76% -7.74%
==========================================
Files 134 218 +84
Lines 12329 14784 +2455
==========================================
+ Hits 6719 6913 +194
- Misses 5116 7069 +1953
- Partials 494 802 +308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sathieu
force-pushed
the
empty-matchConditions
branch
2 times, most recently
from
4989188 to
93b81ab
Compare
Signed-off-by: Mathieu Parent <[email protected]>
sathieu
force-pushed
the
empty-matchConditions
branch
from
93b81ab to
36df3cf
Compare
|
@ritazh @maxsmythe @JaydipGabani Please review 🙏 . |
|
@JaydipGabani Thanks for approving. How to move this forward? |
|
@sathieu I am waiting on others to approve as well. We need at least one more approval to merge it. |
|
Sorry for the delay. Closing as a dupe of #3412 (which has been fully approved). Please re-open the PR if it is not a dupe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#3343 introduced
matchConditionssupport in webhooks, which is great.However for Kubernetes < 1.30, this feature is behind a feature gate, not enabled by default.
in our setup, this causes ArgoCD to show a diff, and the app is
OutOfSyncWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: