ci: push container images to ghcr.io as well #3658
Conversation
dulltz
force-pushed
the
feature/release-to-ghcr
branch
2 times, most recently
from
d13fc9d to
8a082f4
Compare
dulltz
force-pushed
the
feature/release-to-ghcr
branch
2 times, most recently
from
f29dedb to
6148782
Compare
Signed-off-by: TakahiroTsuruda <[email protected]>
dulltz
force-pushed
the
feature/release-to-ghcr
branch
from
6148782 to
0804e02
Compare
.github/workflows/release.yaml
Outdated
| - name: Build and push ghcr.io/${{ env.IMAGE_REPO }} | ||
| if: steps.check-ghcr-image.outputs.exists == 'false' | ||
| run: | | ||
| make REPOSITORY=ghcr.io/${{ env.IMAGE_REPO }} docker-buildx-release \ |
There was a problem hiding this comment.
can you integrate this into the existing release and pre-release flows so artifacts don't get rebuild and digests will be same
There was a problem hiding this comment.
Got it, I'll give it a try and update the PR.
Signed-off-by: TakahiroTsuruda <[email protected]>
sozercan
force-pushed
the
feature/release-to-ghcr
branch
from
6a16cef to
a7c5d95
Compare
Signed-off-by: Sertac Ozercan <[email protected]>
|
|
||
| jobs: | ||
| tagged-release: | ||
| name: "Tagged Release" | ||
| runs-on: "ubuntu-22.04" | ||
| permissions: | ||
| contents: write | ||
| packages: write |
There was a problem hiding this comment.
@dulltz pushed a change to mainly move packages permission here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3658 +/- ##
==========================================
- Coverage 54.49% 47.57% -6.93%
==========================================
Files 134 236 +102
Lines 12329 19786 +7457
==========================================
+ Hits 6719 9413 +2694
- Misses 5116 9487 +4371
- Partials 494 886 +392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it:
Add GHCR as a destination container registry.
With this change we will be able to pull the container at the following URI:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3652
Special notes for your reviewer:
After merging this PR, container images will appear in Packages section.