-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding enforcement point status, vapgeneratestatus #3686
Changes from 18 commits
a492dcd
c72db95
8c27363
ceedd2d
d65d3c3
8183975
0e40ed2
0238c73
a4f17a3
d67ef29
ae48233
8ef8278
b25ca53
a935efd
c33b601
5dff00d
1afa5ac
9727998
45a53f7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,3 +12,12 @@ const ( | |
// ErrParseCode indicates a problem parsing a ConstraintTemplate. | ||
ErrParseCode = "parse_error" | ||
) | ||
|
||
const ( | ||
// ErrGenerateVAPState indicates a problem generating a VAP. | ||
ErrGenerateVAPState = "error" | ||
// GeneratedVAPState indicates a VAP was generated. | ||
GeneratedVAPState = "generated" | ||
// DeletedVAPState indicates a VAP was deleted. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we still need this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nope! Good catch, removed it. |
||
DeletedVAPState = "deleted" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enforcementPoint can be more than just vap enforcement point right? this var name
vapEnforcementPointStatus
makes it look like its just for the vap EP.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the variable to make it generic.