fix: Add flag to enable/disable referential constraints #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Jaeyoon-Lee
changed the title
David-Jaeyoon-Lee
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3701 +/- ##
==========================================
- Coverage 54.49% 47.56% -6.93%
==========================================
Files 134 236 +102
Lines 12329 19923 +7594
==========================================
+ Hits 6719 9477 +2758
- Misses 5116 9553 +4437
- Partials 494 893 +399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
David-Jaeyoon-Lee
changed the title
David-Jaeyoon-Lee
force-pushed
the
davjlee/refactor/disable-ref-constraints
branch
from
bfe0234 to
7008f88
Compare
… by default. Signed-off-by: David-Jaeyoon-Lee <[email protected]>
Signed-off-by: David-Jaeyoon-Lee <[email protected]>
David-Jaeyoon-Lee
force-pushed
the
davjlee/refactor/disable-ref-constraints
branch
from
7008f88 to
9de4ad9
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
main.go:119
- [nitpick] The description for the flag 'enable-referential-rules' is too long and may be confusing. Consider simplifying it to: 'Enable referential rules. Note: Referential constraints may not always be perfectly enforced due to Kubernetes controller consistency.'
enableReferential = flag.Bool("enable-referential-rules", true, "Enable referential rules. Only use this flag if you know what you're doing; referential rules have edge cases where referential constraints may not be perfectly enforced due to the eventual consistency inherent in Kubernetes controllers")
maxsmythe
reviewed
Dec 5, 2024
Signed-off-by: David-Jaeyoon-Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows gatekeeper to set if referential constraints are enabled to disabled via a flag
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: