Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing wait of vapb deletion #3718

Merged

Conversation

JaydipGabani
Copy link
Contributor

@JaydipGabani JaydipGabani commented Nov 28, 2024

What this PR does / why we need it: Since we are deleting VAPB when constraint is being deleted, this test should not be needed anymore.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3713

Special notes for your reviewer:

Signed-off-by: Jaydip Gabani <[email protected]>
@JaydipGabani JaydipGabani requested a review from a team as a code owner November 28, 2024 00:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.58%. Comparing base (3350319) to head (c7043a6).
Report is 206 commits behind head on master.

Files with missing lines Patch % Lines
...onstrainttemplate/constrainttemplate_controller.go 62.50% 4 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (c7043a6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (c7043a6)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3718      +/-   ##
==========================================
- Coverage   54.49%   47.58%   -6.92%     
==========================================
  Files         134      236     +102     
  Lines       12329    19923    +7594     
==========================================
+ Hits         6719     9480    +2761     
- Misses       5116     9551    +4435     
- Partials      494      892     +398     
Flag Coverage Δ
unittests 47.58% <62.50%> (-6.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritazh
Copy link
Member

ritazh commented Nov 28, 2024

Looks like this is still an issue:

ValidatingAdmissionPolicy 'gatekeeper-k8srequiredlabelsvap' with binding 'gatekeeper-all-must-have-label-scoped' denied request: failed to configure binding: paramKind kind &ParamKind{APIVersion:constraints.gatekeeper.sh/v1beta1,Kind:K8sRequiredLabelsVap,} not yet synced to use for admission

@JaydipGabani
Copy link
Contributor Author

Yeah! I am working on resolving this.

@ritazh ritazh requested a review from a team November 28, 2024 01:38
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
@JaydipGabani JaydipGabani merged commit 9a85a21 into open-policy-agent:master Dec 4, 2024
17 checks passed
@JaydipGabani JaydipGabani deleted the vapb-delete-test branch December 4, 2024 21:01
JaydipGabani added a commit to JaydipGabani/gatekeeper that referenced this pull request Dec 4, 2024
Signed-off-by: Jaydip Gabani <[email protected]>
(cherry picked from commit 9a85a21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vapb should be explicitly removed on constraint or CT delete
5 participants