perf: cost of indexing greatly reduced #7370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
commented
Feb 17, 2025
| var schemaDefinitions = map[SchemaFile]interface{}{} | ||
| var schemaDefinitions = map[SchemaFile]any{} | ||
|
|
||
| var loadOnce = sync.OnceValue(func() error { |
There was a problem hiding this comment.
This just moves initialization from init() to when it's actually needed. This isn't so much about performance, but just that there's no need to init authoziation policy in opa eval, check, etc
anderseknert
force-pushed
the
perf3
branch
5 times, most recently
from
d7b2e71 to
418eebf
Compare
srenatus
approved these changes
Feb 19, 2025
And many smaller performance improvements. The indexer recycling results is one of the most impactful performance improvements as of yet, and alone saves more than 2 million allocations in the Regal lint benchmark. The indexer is also more efficient, as `values` are no longer stored on the struct. Thanks @tsandall for that code! Also included a bunch of small improvements from my perf branches. **Before** ``` 1209043041 ns/op 3255157224 B/op 64026192 allocs/op ``` **After** ``` 1197131792 ns/op 3194124864 B/op 61876276 allocs/op ``` Signed-off-by: Anders Eknert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And many smaller performance improvements. The indexer recycling results is one of the most impactful performance improvements as of yet, and alone saves more than 2 million allocations in the Regal lint benchmark. The indexer is also more efficient, as
valuesare no longer stored on the struct. Thanks @tsandall for that code!Also included a bunch of small improvements from my perf branches.
Before
After