Skip to content

Commit

Permalink
tests/bios-tables-test: Compiler warning fix
Browse files Browse the repository at this point in the history
gcc 7.1.1 in fedora 26 moans about the:
   tables = g_new0(uint32_t, tables_nr)

because it can't convince itself that tables_nr is positive.
This is fallout from g_assert_cmpint no longer necessarily being
no-return;  replace it with a plain g_assert.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Marcel Apfelbaum <[email protected]>
  • Loading branch information
dagrh authored and mstsirkin committed Aug 1, 2017
1 parent 2f6b38d commit 91c38e0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/bios-tables-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ static void test_acpi_rsdt_table(test_data *data)
/* compute the table entries in rsdt */
tables_nr = (rsdt_table->length - sizeof(AcpiRsdtDescriptorRev1)) /
sizeof(uint32_t);
g_assert_cmpint(tables_nr, >, 0);
g_assert(tables_nr > 0);

/* get the addresses of the tables pointed by rsdt */
tables = g_new0(uint32_t, tables_nr);
Expand Down

0 comments on commit 91c38e0

Please sign in to comment.