-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QUIC Workflow #295
Add QUIC Workflow #295
Conversation
We add a GitHub Actions workflow that automates the building, testing, and deployment of Docker images with QUIC support. Signed-off-by: pi-314159 <[email protected]>
Signed-off-by: PI <[email protected]>
Signed-off-by: PI <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this CI -- it brings this demo to what I consider the "perfect" usage state (ready-made dockerimage) -- however, it fails to run as it doesn't have access to the OQS docker hub privileges. This is caused IMO by the code being based in your private fork, @pi-314159 . So, can I ask you move this to open-quantum-safe/oqs-demos instead (branch prefixed "pi-", so we know who did it)? You have all required permissions now and CI should then run OK. Please also check the single question above.
Signed-off-by: PI <[email protected]>
@baentsch GHCI passed. Please check https://github.com/open-quantum-safe/oqs-demos/actions/runs/10505026939 Also, docker images are available at https://hub.docker.com/r/openquantumsafe/nginx-quic We need to update the descriptions for these images on Docker Hub |
Agreed. This is the exact reason why I created USAGE.md files for the other demos: Their text is then verbatim copied to docker hub. The README*.md are for people building/wanting to understand build options; USAGE*.md for pure users of ready-made images (wanting to understand config/usage options). |
Ah, it was just wrong env variable names. Good. |
I'm ready to merge this now if you're okay with it. Regarding the description: If you have access to Docker Hub, could you update the description with links to the following resources? nginx README-QUIC.md (includes example configuration, configuration file locations, and executable location) |
Just added those READMEs at docker hub (surprisingly I still have access there... :), but IMO these files are not sufficiently self-explanatory for the "casual user". But we can do it as an experiment to see whether we get questions (and/or any interest at all :) Alternatively, again tagging @ajbozarth to consider trying these out and providing feedback and/or USAGE-*quic.md files as part of the revitalization activity. |
I still don't understand why CI fails (incl. the new job). Ideas, @pi-314159 ? |
Ha, this PR is from pi-314159/oqs-demos, so it doesn't have access to the Docker credentials. The problem will be resolved once I merge this. |
Signed-off-by: pi-314159 <[email protected]>
update nginx to 1.26.2 Signed-off-by: PI <[email protected]>
Add a GitHub Actions workflow that automates the building, testing, and deployment of Docker images with QUIC support.