Update React, Monaco, and replace rescripts with rewired #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `logs-react`, `playground`, and `inspector` packages to use the latest React, React-DOM, and Monaco Editor versions, and replace `rescripts` with `react-app-rewired`. - **Update dependencies:** - Update `react` and `react-dom` to the latest versions in `packages/playground/package.json`. - Update `monaco-editor` to the latest version in `packages/playground/package.json`. - **Replace `rescripts` with `react-app-rewired`:** - Replace `@rescripts/cli` and `@rescripts/utilities` with `react-app-rewired` in `devDependencies` of `packages/inspector/package.json`, `packages/logs-react/package.json`, and `packages/playground/package.json`. - Update `start`, `build`, and `test` scripts to use `react-app-rewired` in `packages/inspector/package.json`, `packages/logs-react/package.json`, and `packages/playground/package.json`. - **Rename and update configuration files:** - Rename `packages/inspector/monaco-rescript.js` to `packages/inspector/config-overrides.js` and update content to use `MonacoWebpackPlugin`. - Rename `packages/logs-react/rescript-monaco.js` to `packages/logs-react/config-overrides.js` and update content to use `MonacoWebpackPlugin`. - Rename `packages/playground/rescript-monaco.js` to `packages/playground/config-overrides.js` and update content to use `MonacoWebpackPlugin`. - **Remove unnecessary scripts:** - Remove `turbo run` commands from `scripts` in `packages/playground/package.json`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/open-rpc/tools?shareId=XXXX-XXXX-XXXX-XXXX).
shanejonas
commented
Nov 28, 2024
packages/playground/package.json
Outdated
| @@ -78,7 +72,7 @@ | |||
| "typescript": "^3.7.3" | |||
| }, | |||
| "rescripts": [ | |||
…kage.json` to use `react-app-rewired` * **`packages/inspector/package.json`** - Replace `@rescripts/cli` and `@rescripts/utilities` with `react-app-rewired` in `devDependencies` - Update `test` script to use `react-app-rewired` - Remove `rescripts` entry * **`packages/playground/package.json`** - Replace `@rescripts/cli` and `@rescripts/utilities` with `react-app-rewired` in `devDependencies` - Remove `rescripts` entry
Update `logs-react`, `playground`, and `inspector` to the latest `react`, `react-dom`, and `monaco`, and replace `rescripts` with `react-app-rewired`. * Update `react` and `react-dom` to version `18.2.0` in `packages/logs-react/package.json`, `packages/playground/package.json`, and `packages/inspector/package.json`. * Update `monaco-editor` to version `0.34.1` in `packages/logs-react/package.json`, `packages/playground/package.json`, and `packages/inspector/package.json`. * Replace `rescripts` with `react-app-rewired` in `packages/logs-react/package.json`, `packages/playground/package.json`, and `packages/inspector/package.json`. * Rename `rescript-monaco.js` to `config-overrides.js` and ensure the `MonacoWebpackPlugin` configuration is equivalent to the old `rescript-monaco.js` in `packages/playground/config-overrides.js`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/open-rpc/tools?shareId=XXXX-XXXX-XXXX-XXXX).
BelfordZ
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
logs-react,playground, andinspectorpackages to use the latest React, React-DOM, and Monaco Editor versions, and replacerescriptswithreact-app-rewired.Update dependencies:
reactandreact-domto the latest versions inpackages/playground/package.json.monaco-editorto the latest version inpackages/playground/package.json.Replace
rescriptswithreact-app-rewired:@rescripts/cliand@rescripts/utilitieswithreact-app-rewiredindevDependenciesofpackages/inspector/package.json,packages/logs-react/package.json, andpackages/playground/package.json.start,build, andtestscripts to usereact-app-rewiredinpackages/inspector/package.json,packages/logs-react/package.json, andpackages/playground/package.json.Rename and update configuration files:
packages/inspector/monaco-rescript.jstopackages/inspector/config-overrides.jsand update content to useMonacoWebpackPlugin.packages/logs-react/rescript-monaco.jstopackages/logs-react/config-overrides.jsand update content to useMonacoWebpackPlugin.packages/playground/rescript-monaco.jstopackages/playground/config-overrides.jsand update content to useMonacoWebpackPlugin.Remove unnecessary scripts:
turbo runcommands fromscriptsinpackages/playground/package.json.For more details, open the Copilot Workspace session.