Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add @unpervertedkid as a contributor #145

Merged

Conversation

unpervertedkid
Copy link
Contributor

Description

Practice open source contribution while taking the intro.opensauced.pizza course.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

@adiati98
Copy link
Member

adiati98 commented Oct 22, 2023

Hi @unpervertedkid,
Thank you for your PR!

We have merged PRs before yours. So please resolve the conflicts first before we can merge yours :)

And please let us know when it's ready for review!

@unpervertedkid
Copy link
Contributor Author

@adiati98 Done!
You can go ahead with the review

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @unpervertedkid,
Please fix this before we can merge your PR :)

Comment on lines 1007 to 1008
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added a space in these lines. Please remove the space.

@adiati98
Copy link
Member

Hey @unpervertedkid
As we're waiting for your changes, we've merged in another PR. So, please resolve the conflicts first. Thank you 🙂

auto-merge was automatically disabled October 23, 2023 16:25

Head branch was pushed to by a user without write access

@unpervertedkid unpervertedkid force-pushed the feature/add-profile-unpervertedkid branch from a381e60 to 439aff2 Compare October 23, 2023 16:25
@unpervertedkid
Copy link
Contributor Author

@adiati98 Can you check it now? Sorry I took a while to respond.

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, @unpervertedkid! 🙌
Thank you for the changes! 😄

If you haven't, come and join our community Discord. 😊
Also, check out our pizza-verse repo if you want to contribute further! 🍕

git merge GIF

@adiati98 adiati98 merged commit 8a11f46 into open-sauced:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants