Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add @vaibhav3022 to the guestbook #161

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

vaibhav3022
Copy link
Contributor

@vaibhav3022 vaibhav3022 commented Oct 27, 2023

Description

Add vaibhav3022 to the guestbook.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@CBID2 CBID2 enabled auto-merge October 27, 2023 21:35
@CBID2 CBID2 requested a review from BekahHW October 27, 2023 21:38
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vaibhav3022,
Thank you for your PR!

I left a review here. Also, you missed the step 6 to generate your profile on the README.

Please fix them before your PR can be merged. Let me know if you need any help! :)

.all-contributorsrc Outdated Show resolved Hide resolved
@adiati98
Copy link
Member

@vaibhav3022

You can change the PR title to: "Add {your-username} to the guestbook".
Right now, just by looking at this PR, we have no idea what are you adding here. :)

Please also complete the PR form. Completing the form, especially the description, will help maintainers to understand your changes.

@adiati98 adiati98 changed the title add docs: Add @vaibhav3022 to the guestbook Oct 30, 2023
@adiati98 adiati98 disabled auto-merge October 30, 2023 17:06
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vaibhav3022 ,
We've generated the README, resolved the merge conflicts, and merged your PR! πŸŽ‰

Check out this section about how to resolve conflicts for your future reference.

Also, in the future, please:

  • Push your working branch instead of your main branch when creating PR.
  • Write a descriptive title.
  • Complete the PR form and describe the changes clearly. Doing so will help maintainers to review and understand the changes in your PR, and will it benefit you as well. πŸ™‚

If you haven't, you can join our community Discord. 😊
Also, check out our pizza-verse repo if you want to contribute further! πŸ•

pizza GIF

@adiati98 adiati98 merged commit f06e57e into open-sauced:main Oct 30, 2023
@vaibhav3022 vaibhav3022 removed their assignment Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants