Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Commit

Permalink
feat(hero): enhance accessibility and seo for hero
Browse files Browse the repository at this point in the history
This PR adds more accessibility to the hero section and also seo bost becuase search engine crawlers
understand more the semantic html

feat #530
  • Loading branch information
sohaibchebah committed Aug 15, 2024
1 parent a8f5b88 commit 657767e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/components/Hero.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
const Hero = () => (
<section aria-labelledby="hero-heading" className="flex flex-col py-24 items-center mx-2.5">
<section
aria-labelledby="hero-heading"
className="flex flex-col py-24 items-center mx-2.5">

Check failure on line 4 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

The closing bracket must be aligned with the opening tag (expected column 3 on the next line)

Check failure on line 4 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

The closing bracket must be aligned with the opening tag (expected column 3 on the next line)

Check failure on line 4 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

The closing bracket must be aligned with the opening tag (expected column 3 on the next line)

Check failure on line 4 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

The closing bracket must be aligned with the opening tag (expected column 3 on the next line)

Check failure on line 4 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

The closing bracket must be aligned with the opening tag (expected column 3 on the next line)

Check failure on line 4 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

The closing bracket must be aligned with the opening tag (expected column 3 on the next line)

Check failure on line 4 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

The closing bracket must be aligned with the opening tag (expected column 3 on the next line)
<div>
<h1
id="hero-heading"
className="font-Lexend text-4xl md:text-5xl text-center text-lightSlate leading-tight tracking-tight"
id="hero-heading"
>
{`Find `}
<span

Check warning on line 11 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

JSX element should start in a new line

Check warning on line 11 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

JSX element should start in a new line

Check warning on line 11 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

JSX element should start in a new line

Check warning on line 11 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

JSX element should start in a new line

Check warning on line 11 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

JSX element should start in a new line

Check warning on line 11 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

JSX element should start in a new line

Check warning on line 11 in src/components/Hero.tsx

View workflow job for this annotation

GitHub Actions / Code standards

JSX element should start in a new line
Expand Down

0 comments on commit 657767e

Please sign in to comment.