Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pin changelog when scrolling #200

Merged
merged 1 commit into from
Feb 6, 2024
Merged

feat: pin changelog when scrolling #200

merged 1 commit into from
Feb 6, 2024

Conversation

zeucapua
Copy link
Contributor

@zeucapua zeucapua commented Feb 5, 2024

Description

When scrolling through /changelog, the title will become sticky until the entire changelog scrolls by.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Addresses #191

Mobile & Desktop Screenshots/Recordings

Screen.Recording.2024-02-05.at.2.27.47.PM.mov

Steps to QA

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

sticky af

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 4285327
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/65c1624ddc0c6000088ebbb9
😎 Deploy Preview https://deploy-preview-200--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeucapua zeucapua requested a review from bdougie February 5, 2024 22:34
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the deploy preview and pulled it down locally, but it doesn't seem to stick as you scroll the changelog, in Chrome. I see it working in the video though. Maybe a commit wasn't pushed?

@zeucapua
Copy link
Contributor Author

zeucapua commented Feb 5, 2024

I tried the deploy preview and pulled it down locally, but it doesn't seem to stick as you scroll the changelog, in Chrome. I see it working in the video though. Maybe a commit wasn't pushed?

Screen.Recording.2024-02-05.at.3.07.43.PM.mov

Opening it up via the preview deploy works for me. It doesn't sticky if the content isn't expanded on the right since there isn't enough height to scroll through, but otherwise looks fine. Mind sending a video on how it looks for you?

@nickytonline
Copy link
Member

I see it working now. I had the sections collapsed which is why it wasn't kicking in.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zeucapua! Works great! 🚢

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zeucapua!

@bdougie bdougie merged commit 3e14b48 into main Feb 6, 2024
6 checks passed
@bdougie bdougie deleted the feat/pin-changelog branch February 6, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants