-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pin changelog when scrolling #200
Conversation
✅ Deploy Preview for opensauced-landing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the deploy preview and pulled it down locally, but it doesn't seem to stick as you scroll the changelog, in Chrome. I see it working in the video though. Maybe a commit wasn't pushed?
Screen.Recording.2024-02-05.at.3.07.43.PM.movOpening it up via the preview deploy works for me. It doesn't sticky if the content isn't expanded on the right since there isn't enough height to scroll through, but otherwise looks fine. Mind sending a video on how it looks for you? |
I see it working now. I had the sections collapsed which is why it wasn't kicking in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zeucapua! Works great! 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @zeucapua!
Description
When scrolling through
/changelog
, the title will become sticky until the entire changelog scrolls by.What type of PR is this? (check all applicable)
Related Tickets & Documents
Addresses #191
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2024-02-05.at.2.27.47.PM.mov
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?