Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Root command persistent flags are marked hidden correctly #126

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jpmcb
Copy link
Member

@jpmcb jpmcb commented Aug 30, 2024

Description

Root command now correctly marks persistent flags as hidden. It was giving:

❯ ./build/pizza
2024/08/30 11:01:05 error marking endpoint as hidden: flag "endpoint" does not exist

Related Tickets & Documents

Followup to #113

Steps to QA

  1. Build via just build
  2. Run with ./build/pizza and output is corrected

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

@jpmcb jpmcb requested a review from a team August 30, 2024 17:16
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired with @jpmcb on this so LGTM! 🚢

@jpmcb jpmcb merged commit 727a82e into beta Aug 30, 2024
9 checks passed
@jpmcb jpmcb deleted the root-persistent-flags branch August 30, 2024 17:45
open-sauced bot pushed a commit that referenced this pull request Aug 30, 2024
## [1.2.1-beta.1](v1.2.0...v1.2.1-beta.1) (2024-08-30)

### 🐛 Bug Fixes

* Root command persistent flags are marked hidden correctly ([#126](#126)) ([727a82e](727a82e))
open-sauced bot pushed a commit that referenced this pull request Aug 30, 2024
## [1.2.1](v1.2.0...v1.2.1) (2024-08-30)

### 🐛 Bug Fixes

* Root command persistent flags are marked hidden correctly ([#126](#126)) ([727a82e](727a82e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants