Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update CODEOWNERS copy with command #130

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Conversation

zeucapua
Copy link
Contributor

Description

Updates the CODEOWNERS copy with the command that generated it with flags.

Related Tickets & Documents

Closes #118

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

cmd/generate/codeowners/output.go Outdated Show resolved Hide resolved
cmd/generate/codeowners/output.go Outdated Show resolved Hide resolved
cmd/generate/codeowners/output.go Outdated Show resolved Hide resolved
cmd/generate/codeowners/output.go Outdated Show resolved Hide resolved
@zeucapua zeucapua requested review from jpmcb and a team September 3, 2024 16:58
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really great! Very nice work! Tricky one for your first Go PR! 🐹

cmd/generate/codeowners/output.go Outdated Show resolved Hide resolved
cmd/generate/codeowners/output.go Outdated Show resolved Hide resolved
@zeucapua zeucapua requested a review from jpmcb September 3, 2024 19:53
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from John's feedback, which appears to have all been answered/updated, this is good to go.

🚢

Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! 👍🏼 👍🏼

@jpmcb jpmcb merged commit a477959 into beta Sep 4, 2024
9 checks passed
open-sauced bot pushed a commit that referenced this pull request Sep 4, 2024
## [1.3.0-beta.2](v1.3.0-beta.1...v1.3.0-beta.2) (2024-09-04)

### 🍕 Features

* update `CODEOWNERS` copy with command ([#130](#130)) ([a477959](a477959))
@jpmcb jpmcb deleted the feat/codeowners-command-copy branch September 4, 2024 16:15
open-sauced bot pushed a commit that referenced this pull request Sep 6, 2024
## [1.3.0](v1.2.1...v1.3.0) (2024-09-06)

### 🍕 Features

* Create a contributor list after generating codeowners ([#141](#141)) ([72c5d58](72c5d58))
* now the documentation for the pizza-cli can be generated via pizza docs ([#143](#143)) ([3f5d27e](3f5d27e))
* Refactors API client into hand rolled sdk in api/ directory ([#111](#111)) ([e16e889](e16e889))
* support fallback attributions when generating codeowners file ([#145](#145)) ([35af4da](35af4da))
* update `CODEOWNERS` copy with command ([#130](#130)) ([a477959](a477959))

### 🐛 Bug Fixes

* Corrects invalid gosec lint error ([#151](#151)) ([f76527f](f76527f))
* Exhume Posthog functionality ([#147](#147)) ([de091ca](de091ca))
* now fallback .sauced.yaml contents get read ([#135](#135)) ([fd658e5](fd658e5))
* NPM cache now looks at package-lock file ([#136](#136)) ([cd4b8da](cd4b8da))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: update copy in generated CODEOWNERS files
3 participants