fix: now fallback .sauced.yaml contents get read #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
force-pushed
the
nickytonline/config-load-bug
branch
from
a80a91a to
a5324ce
Compare
nickytonline
changed the title
nickytonline
force-pushed
the
nickytonline/config-load-bug
branch
2 times, most recently
from
a04e8ca to
70ca56e
Compare
nickytonline
force-pushed
the
nickytonline/config-load-bug
branch
from
70ca56e to
88da5df
Compare
nickytonline
changed the title
jpmcb
requested changes
Sep 4, 2024
nickytonline
force-pushed
the
nickytonline/config-load-bug
branch
from
d154027 to
48d9e4b
Compare
jpmcb
requested changes
Sep 4, 2024
nickytonline
force-pushed
the
nickytonline/config-load-bug
branch
from
48d9e4b to
1d4506b
Compare
jpmcb
approved these changes
Sep 4, 2024
brandonroberts
approved these changes
Sep 5, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
## [1.3.0-beta.4](v1.3.0-beta.3...v1.3.0-beta.4) (2024-09-05) ### 🐛 Bug Fixes * now fallback .sauced.yaml contents get read ([#135](#135)) ([fd658e5](fd658e5))
open-sauced bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
## [1.3.0](v1.2.1...v1.3.0) (2024-09-06) ### 🍕 Features * Create a contributor list after generating codeowners ([#141](#141)) ([72c5d58](72c5d58)) * now the documentation for the pizza-cli can be generated via pizza docs ([#143](#143)) ([3f5d27e](3f5d27e)) * Refactors API client into hand rolled sdk in api/ directory ([#111](#111)) ([e16e889](e16e889)) * support fallback attributions when generating codeowners file ([#145](#145)) ([35af4da](35af4da)) * update `CODEOWNERS` copy with command ([#130](#130)) ([a477959](a477959)) ### 🐛 Bug Fixes * Corrects invalid gosec lint error ([#151](#151)) ([f76527f](f76527f)) * Exhume Posthog functionality ([#147](#147)) ([de091ca](de091ca)) * now fallback .sauced.yaml contents get read ([#135](#135)) ([fd658e5](fd658e5)) * NPM cache now looks at package-lock file ([#136](#136)) ([cd4b8da](cd4b8da))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, if the repository root .sauced.yaml is the config to use, it's contents get read and loaded. Previously, this was not the case which resulted in an empty attribution list.
Related Tickets & Documents
Closes #134
Mobile & Desktop Screenshots/Recordings
Steps to QA
Note, ensure you do not have a
~/.sauced.yamlto test this.just build./build/pizza generate codeowners ./The tests cover this as well. Just run
just testTier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?