-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced logo #80
Replaced logo #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sandeep18JS,
Thank you for working on this! ✨
For now, I'll assign you to the issue. But next time, please read our contributing guidelines. You need to be assigned to an issue before you can work on the changes. 🙂
Please read the issue carefully. We want you to replace the link in the src
and not adding the logo to the asset.
Can you please:
- remove the logo from the asset
- change the link to the logo
- remove the width
- fix the
alt
with "OpenSauced"
You can refer to this line of code on our app repo.
Please also fix the keyword in Related Tickets to "Fixes", not "Fixes/Relates".
Let me know if you have any question. Thanks!
@Sandeep18JS I'm not sure why I can't assign or tag you in the issue's comment. |
@adiati98 I made the requested changes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sandeep18JS, Is there any reason why you close this PR after it's approved? This PR hasn't been merged yet. It still need one more approval from our team before it can be merged. If you don't want to proceed, I will unassign you from the issue and give it to someone else. Just let me know. Thanks. |
@Sandeep18JS sorry my mistake , yea you can unassign me for now. |
Description
This PR adds the Logo on Documentation.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #79
Added to documentation?