* PVS Studio fix #1217
* PVS Studio fix #1217
Conversation
src/lib_json/json_value.cpp
Outdated
| @@ -840,6 +840,7 @@ bool Value::isConvertibleTo(ValueType other) const { | |||
| (type() == realValue && InRange(value_.real_, 0, maxUInt)) || | |||
| type() == booleanValue || type() == nullValue; | |||
| case realValue: | |||
| return isNumeric() || type() == booleanValue || type() == nullValue; | |||
There was a problem hiding this comment.
We could also use the [[fallthrough]] attribute here to document the intent instead of duplicating code, and that would shut PVS Studio up.
https://en.cppreference.com/w/cpp/language/attributes/fallthrough
I think the duplication here is probably an improvement though. It's almost coincidental that convertibility to realValue and convertibility to booleanValue are the same condition.
src/lib_json/json_value.cpp
Outdated
| @@ -1396,7 +1397,7 @@ String Value::Comments::get(CommentPlacement slot) const { | |||
|
|
|||
| void Value::Comments::set(CommentPlacement slot, String comment) { | |||
| if (!ptr_) { | |||
| ptr_ = std::make_unique<Array>(); | |||
| ptr_ = std::unique_ptr<Array>(new Array()); | |||
There was a problem hiding this comment.
I think we should make a version of make_unique in this file with internal linkage.
It can forward to std::make_unique if __cplusplus indicates that we're on C++14. Then we won't have to deal with the make_unique suggestion again. People are going to keep running jsoncpp through linters and sending PRs if we keep the C++11 raw new unique_ptr creation idiom in place. :)
| if (cs_str == "All") { | ||
| cs = CommentStyle::All; | ||
| } else if (cs_str == "None") { | ||
| if (cs_str == "None") { |
There was a problem hiding this comment.
This seems wrong. Am I missing something here?
There was a problem hiding this comment.
jsoncpp/src/lib_json/json_writer.cpp
Line 1170 in ceae0e3
| @@ -408,7 +408,7 @@ Json::String ToJsonString(const char* toConvert) { | |||
| return Json::String(toConvert); | |||
| } | |||
|
|
|||
| Json::String ToJsonString(Json::String in) { return in; } | |||
| Json::String ToJsonString(const Json::String& in) { return in; } | |||
There was a problem hiding this comment.
You also need to modify the header:
jsoncpp_static.vcxproj -> C:\projects\jsoncpp\lib\Release\jsoncpp_static.lib
main.obj : error LNK2019: unresolved external symbol "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl JsonTest::ToJsonString(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >)" (?ToJsonString@JsonTest@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V23@@Z) referenced in function "public: virtual void __thiscall TestCharReaderAllowSingleQuotesTestissue182::runTestCase(void)" (?runTestCase@TestCharReaderAllowSingleQuotesTestissue182@@UAEXXZ) [C:\projects\jsoncpp\src\test_lib_json\jsoncpp_test.vcxproj]
|
Closing this due to inactivity. Feel free to reopen if you are able to address feedback. |
http://oracle.fly-server.ru/pvs-studio/jsoncpp/