fix: contributing guide link in docs and Eigen Matrix constructor #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kyle-cochran and @vishwa2710, proposed two fixes. I am unable to add you two as the reviewers. How do I go about it when I create the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the contributing guide link to be absolute instead of relative. Markdown and Doxygen handle relative links differently, hence, the Doxygen-generated doc didn't correctly link the contributing guide in README to the desired page. One of the deadlinks pointed out in [fix] dead links in docuementation #249.
Fix for issue in [fix] Build Failure in FiniteDifferenceSolver Due to Eigen Matrix Explicit Constructor Initialization #334