Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Notes not being untracked after selecting the corresponding function from the menu #93

Open
wants to merge 1 commit into
base: dev-master
Choose a base branch
from

Conversation

Erewhon-proj
Copy link

Resolved an issue where notes were not being untracked after selecting the corresponding "untrack" function from the menu.

Now, users can simply remove the tag used to add their notes to the queue and then select the "untrack" method to properly untrack their notes.

@Newdea
Copy link
Collaborator

Newdea commented Dec 15, 2024

hi, thanks for your contribution.
I've tried it a few times, but didn't encounter the problem you mentioned, I guess maybe you didn't notice the setting( untrackWhithReviewTag, set to true will untrack note by menu item of untrack note), if you still have problems after trying it, feel free to raise an issue, describe the problem in detail and upload the data.json, thank you again for your contribution!
Screenshot_2024-12-15-22-37-57-595_md obsidian-edit

@Erewhon-proj
Copy link
Author

Hi, I had the UntrackWithReviewTag option set to false, and when I removed the tag and then performed Untrack Note, the note remained both in the queue on the right and in the JSON file.
This is the reason why I made the pull request.
However, by setting the option to true, it works correctly again.

Erewhon-proj added a commit to Erewhon-proj/obsidian-spaced-repetition-recall that referenced this pull request Dec 16, 2024
Newdea added a commit that referenced this pull request Jan 4, 2025
commit c996882
Author: Erewhon-proj <[email protected]>
Date:   Mon Dec 16 14:09:49 2024 +0100

    fixed duplicated icon (removed #93)

commit dd53681
Author: Erewhon-proj <[email protected]>
Date:   Fri Dec 13 17:32:24 2024 +0100

    fixed Notes Review Queue icon

commit f6a4eb3
Author: Erewhon-proj <[email protected]>
Date:   Wed Dec 11 20:58:19 2024 +0100

    fixed untrack notes method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants