Skip to content

Commit

Permalink
add documentation and warning log for deprecating AccessTokenPassthrough
Browse files Browse the repository at this point in the history
  • Loading branch information
asreehari-splunk committed Jan 29, 2025
1 parent c7921b5 commit 56c1e21
Show file tree
Hide file tree
Showing 3 changed files with 53 additions and 0 deletions.
33 changes: 33 additions & 0 deletions .chloggen/deprecate_access_token_passthrough.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: deprecation

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: signalfxreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "`access_token_passthrough` is deprecated"

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: []

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
- "`access_token_passthrough` is deprecated."
- "Please enable include_metadata in the receiver and add the following config to the batch processor:"
```yaml
batch:
metadata_keys: [X-Sf-Token]
```
# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]
4 changes: 4 additions & 0 deletions receiver/signalfxreceiver/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ var errEmptyEndpoint = errors.New("empty endpoint")
type Config struct {
confighttp.ServerConfig `mapstructure:",squash"` // squash ensures fields are correctly decoded in embedded struct

// Deprecated: `access_token_passthrough` is deprecated.
// Please enable include_metadata in the receiver and add the following config to the batch processor:
// batch:
// metadata_keys: [X-Sf-Token]
splunk.AccessTokenPassthroughConfig `mapstructure:",squash"`
}

Expand Down
16 changes: 16 additions & 0 deletions receiver/signalfxreceiver/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,14 @@ func createMetricsReceiver(
) (receiver.Metrics, error) {
rCfg := cfg.(*Config)

if rCfg.AccessTokenPassthrough {
params.Logger.Warn(
"access_token_passthrough is deprecated. " +
"Please enable include_metadata in the receiver and add " +
"`metadata_keys: [X-Sf-Token]` to the batch processor",
)
}

receiverLock.Lock()
r := receivers[rCfg]
if r == nil {
Expand All @@ -96,6 +104,14 @@ func createLogsReceiver(
) (receiver.Logs, error) {
rCfg := cfg.(*Config)

if rCfg.AccessTokenPassthrough {
params.Logger.Warn(
"access_token_passthrough is deprecated. " +
"Please enable include_metadata in the receiver and add " +
"`metadata_keys: [X-Sf-Token]` to the batch processor",
)
}

receiverLock.Lock()
r := receivers[rCfg]
if r == nil {
Expand Down

0 comments on commit 56c1e21

Please sign in to comment.