-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore spanner receiver, and add new codeowners #35998
Restore spanner receiver, and add new codeowners #35998
Conversation
4027c61
to
7515d83
Compare
lint failure appears unrelated:
|
You may also want to add the new approvers to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/githubgen/allowlist.txt if they are not yet OTel members https://github.com/orgs/open-telemetry/people (This check only runs on mainline so you won't see CI failures in your PR) |
@songy23 done |
class: receiver | ||
stability: | ||
beta: [metrics] | ||
distributions: [contrib] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to create a pull request for Releases repo to re-add the component to the Contrib distro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, i'll do that. It looks like it is currently referencing the 112 release, though, which doesn't include this receiver, so i'm not sure if it will be able to be merged right away.
@codeboten filed #36112 to track. |
thanks @dashpole! much appreciated |
Description
Reverts #35724.
The existing CODEOWNER had moved on. This adds myself as the sponsor of the component, and three members of the spanner team to ensure we don't have a single point of failure.
@dsimil @KiranmayiB @harishbohara11
New codeowners, please approve!
cc @codeboten