Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore spanner receiver, and add new codeowners #35998

Merged

Conversation

dashpole
Copy link
Contributor

Description

Reverts #35724.

The existing CODEOWNER had moved on. This adds myself as the sponsor of the component, and three members of the spanner team to ensure we don't have a single point of failure.

@dsimil @KiranmayiB @harishbohara11

New codeowners, please approve!

cc @codeboten

@dashpole dashpole requested a review from a team as a code owner October 25, 2024 14:39
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 25, 2024
@dashpole
Copy link
Contributor Author

lint failure appears unrelated:

Error: stanza/fileconsumer/attrs/attrs.go:44:6: SA4023: this comparison is always true (staticcheck)
		if err != nil {
		   ^
Error: stanza/fileconsumer/attrs/attrs.go:43:9: SA4023(related information): the lhs of the comparison is the 1st return value of this function call (staticcheck)
		err = r.addOwnerInfo(file, attributes)
		      ^
Error: stanza/fileconsumer/attrs/owner_windows.go:13:20: SA4023(related information): (*github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/attrs.Resolver).addOwnerInfo never returns a nil interface value (staticcheck)
func (r *Resolver) addOwnerInfo(_ *os.File, _ map[string]any) error {

@songy23
Copy link
Member

songy23 commented Oct 25, 2024

You may also want to add the new approvers to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/githubgen/allowlist.txt if they are not yet OTel members https://github.com/orgs/open-telemetry/people

(This check only runs on mainline so you won't see CI failures in your PR)

@dashpole
Copy link
Contributor Author

@songy23 done

@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Oct 28, 2024
class: receiver
stability:
beta: [metrics]
distributions: [contrib]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to create a pull request for Releases repo to re-add the component to the Contrib distro?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, i'll do that. It looks like it is currently referencing the 112 release, though, which doesn't include this receiver, so i'm not sure if it will be able to be merged right away.

@andrzej-stencel andrzej-stencel merged commit 96bd452 into open-telemetry:main Oct 30, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 30, 2024
@codeboten
Copy link
Contributor

Thanks for volunteering to take on this component. Can you have a look at #29830 and #30370

@dashpole
Copy link
Contributor Author

@codeboten filed #36112 to track.

@dashpole dashpole deleted the restore_spanner_receiver branch October 31, 2024 14:39
@codeboten
Copy link
Contributor

thanks @dashpole! much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/githubgen cmd/otelcontribcol otelcontribcol command ready to merge Code review completed; ready to merge by maintainers receiver/googlecloudspanner reports/distributions/contrib.yaml Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants