fix linter errors

Signed-off-by: Moritz Wiesinger <[email protected]>
open-telemetry · Nov 27, 2024 · eeb45e6 · eeb45e6
1 parent d8a1dd6
commit eeb45e6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/cmd/githubgen/codeowners.go b/cmd/githubgen/codeowners.go
@@ -4,6 +4,7 @@ package main
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -176,7 +177,7 @@ func (cg codeownersGenerator) getGithubMembers() (map[string]struct{}, error) {
 	}
 	githubToken := os.Getenv("GITHUB_TOKEN")
 	if githubToken == "" {
-		return nil, fmt.Errorf("Set the environment variable `GITHUB_TOKEN` to a PAT token to authenticate")
+		return nil, errors.New("set the environment variable `GITHUB_TOKEN` to a PAT token to authenticate")
 	}
 	client := github.NewTokenClient(context.Background(), githubToken)
 	var allUsers []*github.User

diff --git a/cmd/githubgen/distributions.go b/cmd/githubgen/distributions.go
@@ -4,7 +4,6 @@
 package main
 
 import (
-	"fmt"
 	"os"
 	"path/filepath"
 	"sort"
@@ -53,7 +52,7 @@ func (cg distributionsGenerator) generate(data *githubData) error {
 		if err != nil {
 			return nil
 		}
-		err = os.WriteFile(filepath.Join("reports", "distributions", fmt.Sprintf("%s.yaml", dist.Name)), b, 0o600)
+		err = os.WriteFile(filepath.Join("reports", "distributions", dist.Name+".yaml"), b, 0o600)
 		if err != nil {
 			return nil
 		}

diff --git a/cmd/githubgen/issuetemplates.go b/cmd/githubgen/issuetemplates.go
@@ -50,7 +50,7 @@ func (itg issueTemplatesGenerator) generate(data *githubData) error {
 		return err
 	}
 	for _, e := range entries {
-		templateContents, err := os.ReadFile(filepath.Join(issuesFolder, e.Name()))
+		templateContents, err := os.ReadFile(filepath.Join(issuesFolder, e.Name())) // nolint: gosec
 		if err != nil {
 			return err
 		}

diff --git a/cmd/githubgen/main.go b/cmd/githubgen/main.go
@@ -6,7 +6,6 @@ package main
 import (
 	"context"
 	"flag"
-	"fmt"
 	"io/fs"
 	"log"
 	"os"
@@ -45,7 +44,7 @@ func main() {
 		case "distributions":
 			generators = append(generators, distributionsGenerator{})
 		default:
-			panic(fmt.Sprintf("Unknown generator: %s", arg))
+			panic("Unknown generator: " + arg)
 		}
 	}
 	if len(generators) == 0 {
@@ -140,7 +139,7 @@ func run(folder string, allowlistFilePath string, generators []generator) error
 			}
 			if m.Status.Codeowners == nil {
 				// TODO to be changed back to fmt.Errorf once codeowners for all components are defined
-				log.Println(fmt.Sprintf("WARNING: component %q has no codeowners section", key))
+				log.Printf("WARNING: component %q has no codeowners section", key)
 				return nil
 			}
 			for _, id := range m.Status.Codeowners.Active {
@@ -164,7 +163,7 @@ func run(folder string, allowlistFilePath string, generators []generator) error
 	sort.Strings(codeownersList)
 
 	var distributions []distributionData
-	dd, err := os.ReadFile(filepath.Join(folder, "distributions.yaml"))
+	dd, err := os.ReadFile(filepath.Join(folder, "distributions.yaml")) // nolint: gosec
 	if err != nil {
 		return err
 	}