Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requirement to solve conversations on RFCs #11737

Closed
mx-psi opened this issue Nov 25, 2024 · 0 comments · Fixed by #11738
Closed

Add requirement to solve conversations on RFCs #11737

mx-psi opened this issue Nov 25, 2024 · 0 comments · Fixed by #11738
Assignees
@mx-psi

Comments

@mx-psi
Copy link
Member

mx-psi commented Nov 25, 2024

From private conversation:

I think it might be reasonable to require that all conversations are solved. However, we could maybe articulate a reasonable way to proceed if a conversation doesn't appear to be going anywhere. e.g. "the author of the RFC may resolve conversations at their discretion but they must explain in the thread why they believe it is appropriate to do so". This pings the people involved and gives them a chance to unresolve/request changes.
@mx-psi mx-psi self-assigned this Nov 25, 2024
@mx-psi mx-psi mentioned this issue Nov 26, 2024
Merged
mx-psi added a commit that referenced this issue Dec 4, 2024
@mx-psi @codeboten
[chore][docs/rfc] Add text regarding conversations (#11738)
bc7af62 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Based on the experience of this process going through once, I am
suggesting we make the following changes:

1. Require announcing the final comment period via a comment and on the
#otel-collector-dev channel.
2. Require that all conversations are resolved. Allow RFC author to
resolve any conversation, but require them to leave a comment explaining
why

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #11737

Co-authored-by: Alex Boten <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
@mx-psi @codeboten @HongChenTW
[chore][docs/rfc] Add text regarding conversations (open-telemetry#11738
7a37ad7 
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Based on the experience of this process going through once, I am
suggesting we make the following changes:

1. Require announcing the final comment period via a comment and on the
#otel-collector-dev channel.
2. Require that all conversations are resolved. Allow RFC author to
resolve any conversation, but require them to leave a comment explaining
why

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes open-telemetry#11737

Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mx-psi mx-psi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore][docs/rfc] Add text regarding conversations mx-psi/opentelemetry-collector
1 participant
@mx-psi