[chore][docs/rfc] Add text regarding conversations #11738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
requested review from
atoulme,
codeboten,
bogdandrutu,
djaglowski and
dmitryax
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11738 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 447 447
Lines 23745 23745
=======================================
Hits 21712 21712
Misses 1657 1657
Partials 376 376 ☔ View full report in Codecov by Sentry. |
andrzej-stencel
approved these changes
Nov 25, 2024
codeboten
approved these changes
Nov 25, 2024
djaglowski
approved these changes
Nov 26, 2024
evan-bradley
approved these changes
Nov 26, 2024
TylerHelmuth
approved these changes
Nov 26, 2024
dmitryax
approved these changes
Nov 27, 2024
mx-psi
added
the
rfc:final-comment-period
|
Given the approvals, this is entering the final comment period. Since we have Thanksgiving I am going to exclude Thursday and Friday and merge on or after 2024-12-04 |
Aneurysm9
approved these changes
Nov 27, 2024
bogdandrutu
approved these changes
Dec 2, 2024
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Based on the experience of this process going through once, I am suggesting we make the following changes: 1. Require announcing the final comment period via a comment and on the #otel-collector-dev channel. 2. Require that all conversations are resolved. Allow RFC author to resolve any conversation, but require them to leave a comment explaining why <!-- Issue number if applicable --> #### Link to tracking issue Fixes open-telemetry#11737 Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the experience of this process going through once, I am suggesting we make the following changes:
Link to tracking issue
Fixes #11737