-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config/confighttp] Resolve the TODO on confighttp.go related to prefixing operations with component id. #9382
Comments
Hi @atoulme I would like to work on this issue. Is there any recommended readings or some files to look at? From what I understand, the span name formatter function can be used as a tool to set the prefix but I couldn't really understand how to get the component ID. |
@enesonus go for it, not sure how to do it |
@atoulme can you assign this to me, I'll take it up. |
I think this can be removed from Collector v1, since we don't provide any stability guarantees for traces |
What is the status of this issue @atoulme @VihasMakwana? I believe the scope is a bit unclear. Do we want to:
The original TODO seems to suggest 1, but this seems to have been abandoned in favor of 2 because the component ID is not available in the confighttp code. If 2 is fine, then I believe this issue was already resolved by #11769, which allows users to use |
I opened this issue to remove this TODO and get the component to stable state. The TODO predates my time with the project. It's been thorny to resolve as everybody ends up guessing what the comment means in the context of the time it was written at. I believe you neatly address it in your comment. I also believe 2. addresses the need. Can we please remove this TODO and close this issue? Would you like to open a PR? |
Alright, I'll do that. |
FYI, I opened a PR (#12351) to add that prefix for the OTLP receiver (and other HTTP receivers will have to do the same independently). |
From confighttp.go:
I have tried to resolve this TODO once before with #9123
The text was updated successfully, but these errors were encountered: