[chore] Remove resolved TODO about span name prefix #12333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Feb 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12333 +/- ##
=======================================
Coverage 91.38% 91.39%
=======================================
Files 468 468
Lines 25610 25624 +14
=======================================
+ Hits 23404 23418 +14
Misses 1790 1790
Partials 416 416 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Feb 10, 2025
bogdandrutu
approved these changes
Feb 10, 2025
|
The idea is the following, there will be lots of HTTP spans, do we need to distinguish between which are for otlpreceiver vs jaegerreceiver? |
codeboten
approved these changes
Feb 10, 2025
Merged
via the queue into
open-telemetry:main
with commit Feb 10, 2025
7f6a9e1
46 of 59 checks passed
|
@bogdandrutu That would be good, yes. But after the two previous implementation attempts, it seems this is most easily done by specifying a SpanNameFormatter in each of these components. (Worst case scenario: looking at the port and path should be unambiguous, though tedious to look up.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deletes the TODO comment that sparked #9382. The original intent is a bit unclear, but it is probably addressed by #11769. See tracking issue for discussion and related PRs.
Link to tracking issue
Resolves #9382