-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[consumer] Add tracing to all the components #10847
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10847 +/- ##
=======================================
Coverage 91.85% 91.86%
=======================================
Files 415 416 +1
Lines 19850 19878 +28
=======================================
+ Hits 18234 18260 +26
- Misses 1244 1245 +1
- Partials 372 373 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Israel Blancas <[email protected]>
…lector into feature/8804
Hi @codeboten can you take a look to this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has the same downsides of the original PR which is that it exposes additional interface for the consumer package. I suggested #8910 as an alternative implementation but there were some challenges with that one as well.
Pinging @dmitryax and @bogdandrutu as they reviewed the original PRs
Sorry. Didn't see that one. I would happily retake the other approach if preferred or research any possible improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be outside the scope of this PR but it would be nice if, as we are adding telemetry to components, we could make sure we're using the attributes described on #11179.
Closing singe more discussion is needed. |
Description
Add tracing to all the components
Link to tracking issue
Fixes #8804
Testing
Based on #8833