Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logs scraper #12116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sincejune
Copy link
Contributor

Description

This PR:

  1. Added support for logs scraper
  2. Deprecated AddScraper in favor of AddMetricsScraper

Link to tracking issue

Relevant to #11238

Testing

Added

Documentation

Added

@sincejune sincejune requested a review from a team as a code owner January 17, 2025 15:22
@sincejune sincejune requested a review from mx-psi January 17, 2025 15:22
@mx-psi mx-psi requested a review from bogdandrutu January 17, 2025 15:39
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 89.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (a3c7d95) to head (91dfee9).

Files with missing lines Patch % Lines
scraper/scraperhelper/controller.go 83.78% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12116      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files         461      461              
  Lines       24749    24798      +49     
==========================================
+ Hits        22689    22732      +43     
- Misses       1678     1682       +4     
- Partials      382      384       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sincejune sincejune force-pushed the support-logs-scraper branch 2 times, most recently from c99f960 to 9cbf911 Compare January 18, 2025 06:55
@sincejune sincejune force-pushed the support-logs-scraper branch from 9cbf911 to 91dfee9 Compare January 18, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant