Skip to content

Commit

Permalink
[cart] - fix cartServiceFailure flag (#1313)
Browse files Browse the repository at this point in the history
* fix cartServiceFailure flag

Signed-off-by: Pierre Tessier <[email protected]>

* fix cartServiceFailure flag

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
  • Loading branch information
puckpuck and julianocosta89 authored Jan 2, 2024
1 parent 326ffe4 commit b55b147
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ release.

* [cartservice] disable config reload
([#1312](https://github.com/open-telemetry/opentelemetry-demo/pull/1312))
* [cartservice] fixed cartServiceFailure feature flag
([#1313](https://github.com/open-telemetry/opentelemetry-demo/pull/1313))
* [accountingservice] Update dependencies and semconv
* ([#1316](https://github.com/open-telemetry/opentelemetry-demo/pull/1316))

Expand Down
1 change: 1 addition & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ services:
- "${CART_SERVICE_PORT}"
environment:
- CART_SERVICE_PORT
- FEATURE_FLAG_GRPC_SERVICE_ADDR
- REDIS_ADDR
- OTEL_EXPORTER_OTLP_ENDPOINT
- OTEL_RESOURCE_ATTRIBUTES
Expand Down
4 changes: 0 additions & 4 deletions src/cartservice/src/featureflags/FeatureFlagHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ public async Task<bool> GenerateCartError()
{
return false;
}
if (Random.Next(10) != 1)
{
return false;
}

var getFlagRequest = new GetFlagRequest { Name = "cartServiceFailure" };
var getFlagResponse = await _featureFlagServiceClient.GetFlagAsync(getFlagRequest);
Expand Down

0 comments on commit b55b147

Please sign in to comment.