Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a static SQL dump to seed the ffs_postgres database #1322

Closed

Conversation

joshleecreates
Copy link
Contributor

Changes

As discussed with @puckpuck — this change seeds the ffs_postgres database using a SQL dump file and an init script. This simplifies setup for the featureflagservice as no Ecto migrations need to be run. One drawback of this change is that it changes the ffs_postgres from using an off-the-shelf image to using a built image. A bonus advantage is that the featureflagservice starts up a bit faster.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@joshleecreates joshleecreates requested a review from a team January 7, 2024 21:03
@puckpuck
Copy link
Contributor

puckpuck commented Jan 8, 2024

#1319 covers all of this and cleans up the protobuf to remove unnecessary items.

@joshleecreates
Copy link
Contributor Author

Cool 😎

@joshleecreates joshleecreates deleted the ffs-db-dump-seeder branch January 8, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants